feat: add security scanning tools to dev prerequisites #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pre-commit, detect-secrets, and osv-scanner to the prerequisite checks. These tools were added in PR #145 but the prerequisite check wasn't updated, so developers aren't warned when they're missing. All three are marked as optional (required: false) since they're only needed for security scanning workflows, not core development.
github-actions
bot
added
the
component:smartem-workspace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Problem
PR #145 added security scanning tools (pre-commit hooks, detect-secrets baseline, osv-scanner) but didn't update the prerequisite check. Developers aren't warned when these tools are missing from their environment.
Solution
Add the three tools to
dev-requirements.json:All marked as optional (
required: false) since they're only needed for security scanning workflows, not core development.Test plan
smartem-workspace check --scope dev-requirementswith tools installedsmartem-workspace check --scope dev-requirementswith tools missing (should show warnings, not errors)